docs: add floci integration documentation - #1373
Conversation
- Add Floci UI web console integration examples for C# and TypeScript - Include customization options for container name and host port - Add note about Floci's built-in UI mechanism vs Aspire resource - Enhance Quarkus configuration section with standard location reference - Add clarification about FLOCI_ prefixed environment variables - Improve TLS/HTTPS section structure with better documentation - Detail port routing behavior for TLS connections
1319131 to
9b623a6
Compare
Alistair Matthews (alistairmatthews)
left a comment
There was a problem hiding this comment.
This is great. Just a few minor style and grammar suggestions. Thanks!
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
Co-authored-by: Alistair Matthews <alistairwebdojo@live.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Aspire integration documentation page for Floci and wires it into the frontend’s integration navigation and package metadata lists so it shows up in the site and integration lookups.
Changes:
- Added new Floci integration documentation page under Compute integrations.
- Registered the Floci integration in the site’s integration docs mapping and integrations metadata list.
- Added Floci to the Compute & hosting sidebar topic list.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/src/data/integration-docs.json | Maps the Floci integration package ID to the new docs route. |
| src/frontend/src/data/aspire-integrations.json | Adds Floci to the integrations catalog metadata (title/description/tags/version). |
| src/frontend/src/content/docs/integrations/compute/floci.mdx | New integration documentation page content for Floci. |
| src/frontend/src/assets/icons/floci-icon.svg | Adds Floci icon asset. |
| src/frontend/src/assets/icons/floci-icon-light.svg | Adds Floci light icon asset used by the docs page. |
| src/frontend/config/sidebar/integrations.topics.ts | Adds Floci to the Compute sidebar navigation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Adam Ratzman (adamint)
left a comment
There was a problem hiding this comment.
I do not have anything to add beyond the existing review threads.
Alistair Matthews (alistairmatthews)
left a comment
There was a problem hiding this comment.
Thanks for addressing my previous review.
Please address my one suggestion and Copilot's comment about unclosed tab and tabitem blocks. Then this is ready to go.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alistair Matthews <a.matthews@reddoorcollaborative.com>
|
Thanks for reviewing my PR. I fixed the issues with tabs, and now I am waiting for the package to be published so it exist and as soon as is present we can merge it. |
Alistair Matthews (alistairmatthews)
left a comment
There was a problem hiding this comment.
Ready to merge.
CommunityToolkit.Aspire.Hosting.Floci is not yet published on nuget.org, so the integration data refresh correctly drops it from aspire-integrations.json. The docs added in #1373 (doc mapping, page, sidebar entry, and icons) still referenced a package absent from the catalog, which failed the update-integrations guardrail test ("only maps packages in the current integration catalog"). Remove the Floci docs footprint until the package ships. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Issue: floci-io/floci#1242
Integration: CommunityToolkit/Aspire#1448